refactor: Add TypeScript support by fabiovincenzi · Pull Request #26 · G-Research/git-proxy

fabiovincenzi · 2025-02-17T15:40:49Z

Overview
This PR introduces TypeScript to git-proxy and refactors relevant code to support it.

Changelog

Added TypeScript configuration (tsconfig.json) with essential settings for strict type checking, ES6 compatibility, and JSX support.
Added typescript and ts-node to manage TypeScript code compilation and execution.
Updated the package.json to include TypeScript dependencies.
Converted the main entry file from JavaScript (index.js) to TypeScript (index.ts).
Modified the start script to use ts-node for running TypeScript files.

06kellyjac · 2025-02-27T15:29:35Z

Should be fine to adopt this upstream if you're happy to open a PR.
We might want to double check we build out the right files for publishing but otherwise looks good.
A good pre-req for the db refactor & best to bring this in ahead of that :)

fabiovincenzi · 2025-02-27T17:20:21Z

Should be fine to adopt this upstream if you're happy to open a PR. We might want to double check we build out the right files for publishing but otherwise looks good. A good pre-req for the db refactor & best to bring this in ahead of that :)

Thanks for the review @06kellyjac !
Yes, I'll open a PR on the upstream then we can go ahead with db refactor.

src/db/mongo/pushes.js

codecov-commenter · 2025-02-28T10:28:39Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

…ores

…flows/unused-dependencies.yml

…github-actions chore(deps): update dependency node to v22 - workflows - .github/workflows/unused-dependencies.yml

chore(deps): update dependency sinon to v20 - - package.json

…ckage.json

fix(deps): update dependency eslint to ^9.30.1 - website - website/package.json

fix(deps): update npm - li-cli - experimental/li-cli/package.json

chore(deps): update dependency sinon to v21 - - package.json

…tory - experimental/license-inventory/docker-compose.yaml

…ajor-12-docker-compose chore(deps): update grafana/grafana docker tag to v12 - license-inventory - experimental/license-inventory/docker-compose.yaml

fix(deps): update dependency body-parser to v2 - - package.json

- allow for the setting of configuration for MongoDB database connection string as well as cookie secret via environment variables as an alternative to JSON-based configuration Useful in environments that split config between secrets (ie. stored in a secret manager) and plain app configurations such as commitConfig, attestation, etc. that may not be considered sensitive & wouldn't be appropriate in a secret manager.

Signed-off-by: Fabio Vincenzi <93596376+fabiovincenzi@users.noreply.github.com>

fix(proxy): preserve original Git pack POST streams before validation

feat: mongo connection string & cookie secret from env vars

…li-cli/package.json

fix(deps): update dependency zod to ^3.25.73 - li-cli - experimental/li-cli/package.json

fabiovincenzi self-assigned this Feb 17, 2025

fabiovincenzi linked an issue Feb 17, 2025 that may be closed by this pull request

[Setup] Add TypeScript to the Project #16

Closed

3 tasks

jescalada mentioned this pull request Feb 24, 2025

refactor(ts): refactor db module to use TS and ESM #27

Closed

github-advanced-security bot found potential problems Feb 28, 2025

View reviewed changes

src/db/mongo/pushes.js Fixed Show fixed Hide fixed

fabiovincenzi changed the title ~~Add TypeScript support~~ refactor: Add TypeScript support Mar 10, 2025

github-actions bot added the automation label Mar 10, 2025

JamieSlome and others added 21 commits March 24, 2025 12:24

Merge branch 'main' into typescript-setup

5211d0e

Merge branch 'main' into typescript-setup

773754e

feat: support direct querying of AD group membership via LDAP

1400d9b

test: don't clean-up test-repo as cypress tests rely on it

f552624

fix(auth): remove jwt data from config and disable by default

cb3d110

feat(auth): add role mapping and assignment on jwt claims

fdaeb6b

test(auth): add test for getJwks helper

5e1440e

chore(auth): move jwt util functions into own file for testing

24cba4d

test(auth): add test for validateJwt helper function

dad5beb

test(auth): add test for assignRoles helper function

407cb85

test(auth): add tests for jwtAuthHandler

420be8d

chore: add missing jwtConfig parameter (optional)

5bdcd69

Merge remote-tracking branch 'origin/main' into jwt-claims-role-mapping

8decdea

fix: fix failing tests

aee4b4f

fix: remove unneeded oidc config params and values

583616a

fix: fix linter and test issues

f31bc6d

fix: e2e test fail due to route refactor (admin -> dashboard)

412b209

fix: e2e test fail (login required)

336e51d

Merge branch 'main' into 909-ldap-user-group-confirmation

189ec0c

Merge branch 'main' into typescript-setup

b6b19d0

chore: enable TS declarations, add build step to workflow, update ign…

50327f6

…ores

renovate bot and others added 28 commits July 1, 2025 16:09

chore(deps): update dependency node to v22 - workflows - .github/work…

1a58e46

…flows/unused-dependencies.yml

chore(deps): update dependency sinon to v20 - - package.json

2b81d59

Merge pull request finos#1077 from finos/renovate/workflows-major-22-…

e262c0e

…github-actions chore(deps): update dependency node to v22 - workflows - .github/workflows/unused-dependencies.yml

Merge branch 'main' into renovate/major-20-npm

d2e9322

Merge pull request finos#1078 from finos/renovate/major-20-npm

35a946b

chore(deps): update dependency sinon to v20 - - package.json

fix(deps): update dependency eslint to ^9.30.1 - website - website/pa…

43a7072

…ckage.json

Merge pull request finos#1079 from finos/renovate/website-manager

d7f3074

fix(deps): update dependency eslint to ^9.30.1 - website - website/package.json

fix(deps): update npm - li-cli - experimental/li-cli/package.json

431d0ef

Merge pull request finos#1080 from finos/renovate/li-cli-manager

8c35edd

fix(deps): update npm - li-cli - experimental/li-cli/package.json

chore(deps): update dependency sinon to v21 - - package.json

c1325c6

Merge pull request finos#1081 from finos/renovate/major-21-npm

eee8858

chore(deps): update dependency sinon to v21 - - package.json

chore(deps): update grafana/grafana docker tag to v12 - license-inven…

975df0a

…tory - experimental/license-inventory/docker-compose.yaml

Merge pull request finos#1082 from finos/renovate/license-inventory-m…

a0bb2ef

…ajor-12-docker-compose chore(deps): update grafana/grafana docker tag to v12 - license-inventory - experimental/license-inventory/docker-compose.yaml

fix(deps): update dependency body-parser to v2 - - package.json

9293a41

Merge branch 'main' into clone-fix

daee018

Merge pull request finos#1084 from finos/renovate/major-2-npm

75fb0e6

fix(deps): update dependency body-parser to v2 - - package.json

Merge branch 'main' into clone-fix

a5eb9f2

Signed-off-by: Fabio Vincenzi <93596376+fabiovincenzi@users.noreply.github.com>

fix: remove .only in tests

90f6806

refactor: remove unused dependancy

57c65cb

fix: use git-proxy repo in repo cypress test

735c634

fix: fix blocked request test

37d9464

Merge pull request finos#1060 from fabiovincenzi/clone-fix

f96a8c4

fix(proxy): preserve original Git pack POST streams before validation

Merge branch 'main' into feat/mongo-env

a007613

Merge pull request finos#1086 from RBC/feat/mongo-env

53fded7

feat: mongo connection string & cookie secret from env vars

fix(deps): update dependency zod to ^3.25.73 - li-cli - experimental/…

4421930

…li-cli/package.json

Merge pull request finos#1085 from finos/renovate/li-cli-manager

29d0e34

fix(deps): update dependency zod to ^3.25.73 - li-cli - experimental/li-cli/package.json

Merge branch 'main' into typescript-setup

c1128c4

fabiovincenzi closed this by deleting the head repository Aug 4, 2025

fabiovincenzi removed a link to an issue Aug 18, 2025

[Setup] Add TypeScript to the Project #16

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Add TypeScript support#26

refactor: Add TypeScript support#26
fabiovincenzi wants to merge 175 commits intoG-Research:mainfrom
fabiovincenzi:typescript-setup

fabiovincenzi commented Feb 17, 2025

Uh oh!

06kellyjac commented Feb 27, 2025

Uh oh!

fabiovincenzi commented Feb 27, 2025

Uh oh!

Uh oh!

codecov-commenter commented Feb 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

fabiovincenzi commented Feb 17, 2025

Uh oh!

06kellyjac commented Feb 27, 2025

Uh oh!

fabiovincenzi commented Feb 27, 2025

Uh oh!

Uh oh!

codecov-commenter commented Feb 28, 2025

Welcome to Codecov 🎉

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants