Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker image building by upgrading to Go 1.17 #96

Merged
merged 4 commits into from
Jan 20, 2022

Conversation

jgiannuzzi
Copy link
Member

@jgiannuzzi jgiannuzzi commented Jan 19, 2022

We should probably upgrade to a newer version of Go, but at least this makes Geras buildable again.

Ran go tidy, upgraded Go version in go.mod to 1.17, and fixed the warning during grpc-health-probe installation.

@dgl
Copy link
Contributor

dgl commented Jan 19, 2022

FWIW, the fix is literally running go get as the error points out:

--- a/go.mod
+++ b/go.mod
@@ -5,6 +5,7 @@ go 1.15
 require (
        github.com/G-Research/opentsdb-goclient v0.0.0-20191219203319-f9f2aa5b26
24
        github.com/go-kit/kit v0.9.0
+       github.com/grpc-ecosystem/go-grpc-middleware v1.0.0 // indirect

That works on go 1.17. The breakage was kind of deliberate, go 1 compatibility promise means code shouldn't have to change, but there might be small tooling fixes, which it's worth keeping up with.

@jgiannuzzi
Copy link
Member Author

Thanks for pointing this out @dgl!

I will update my PR to upgrade properly to Go 1.17 and run go tidy.

@jgiannuzzi jgiannuzzi changed the title Fix Docker image building by pinning the Go SDK to 1.15.x Fix Docker image building by upgrading to Go 1.17 Jan 19, 2022
Copy link
Contributor

@kradalby kradalby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me :)

@jgiannuzzi jgiannuzzi merged commit beeb0dd into G-Research:master Jan 20, 2022
@jgiannuzzi jgiannuzzi deleted the fix-docker-build branch January 20, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants