Fix stringanalyzers for netstandard

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## [0.1.3] - 2023-10-11
+* Fix StringAnalyzers for netstandard projects
+
 ## [0.1.2] - 2023-10-10
 * Update FSharp.Analyzers.SDK to `0.15.0`
 

src/FSharp.Analyzers/StringAnalyzer.fs

@@ -39,7 +39,8 @@ let invalidStringFunctionUseAnalyzer
     let handler : Handler =
         Handler.CallHandler (fun (m : range) (mfv : FSharpMemberOrFunctionOrValue) (args : FSharpExpr list) ->
             if
-                mfv.Assembly.SimpleName = "System.Runtime"
+                (mfv.Assembly.SimpleName = "System.Runtime"
+                 || mfv.Assembly.SimpleName = "netstandard")
                 && mfv.FullName = $"System.String.{functionName}"
                 && typedArgumentPredicate args
             then

tests/data/string/endswith/Constant String - Single Argument.fs

@@ -1 +1,3 @@
+module M
+
 "foo".EndsWith("p")

tests/data/string/endswith/Constant String - Single Argument.fs.expected

@@ -1 +1 @@
-GRA-STRING-001 | Warning | (1,0 - 1,19) | The usage of String.EndsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.
+GRA-STRING-001 | Warning | (3,0 - 3,19) | The usage of String.EndsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/endswith/Function call - Single Argument.fs

@@ -1,2 +1,4 @@
+module M
+
 let f () = "f"
 "g".EndsWith(f())

tests/data/string/endswith/Function call - Single Argument.fs.expected

@@ -1 +1 @@
-GRA-STRING-001 | Warning | (2,0 - 2,17) | The usage of String.EndsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.
+GRA-STRING-001 | Warning | (4,0 - 4,17) | The usage of String.EndsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/endswith/Prefixed Value - Single Argument.fs

@@ -1,3 +1,5 @@
+module M
+
 module A =
     let b = "b"
 

tests/data/string/endswith/Prefixed Value - Single Argument.fs.expected

@@ -1 +1 @@
-GRA-STRING-001 | Warning | (4,0 - 4,17) | The usage of String.EndsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.
+GRA-STRING-001 | Warning | (6,0 - 6,17) | The usage of String.EndsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/endswith/Value - Single Argument.fs

@@ -1,2 +1,4 @@
+module M
+
 let a = "a"
 a.EndsWith("a")

tests/data/string/endswith/Value - Single Argument.fs.expected

@@ -1 +1 @@
-GRA-STRING-001 | Warning | (2,0 - 2,15) | The usage of String.EndsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.
+GRA-STRING-001 | Warning | (4,0 - 4,15) | The usage of String.EndsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/endswith/negative/Boolean CultureInfo.fs

@@ -1,3 +1,5 @@
+module M
+
 open System.Globalization    
 
 "a".EndsWith("b", false, CultureInfo.InvariantCulture)

tests/data/string/endswith/negative/Char.fs

@@ -1 +1,3 @@
+module M
+
 "a".EndsWith('b')

tests/data/string/endswith/negative/StringComparison.fs

@@ -1 +1,3 @@
+module M
+
 "a".EndsWith("b", System.StringComparison.InvariantCulture)

tests/data/string/indexof/Constant String - Single Argument.fs

@@ -1 +1,3 @@
+module M
+
 "foo".IndexOf("p")

tests/data/string/indexof/Constant String - Single Argument.fs.expected

@@ -1 +1 @@
-GRA-STRING-003 | Warning | (1,0 - 1,18) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.
+GRA-STRING-003 | Warning | (3,0 - 3,18) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/indexof/Constant String - String Int Int.fs

@@ -1 +1,3 @@
+module M
+
 "foo".IndexOf("p", 0 ,1)

tests/data/string/indexof/Constant String - String Int Int.fs.expected

@@ -1 +1 @@
-GRA-STRING-003 | Warning | (1,0 - 1,24) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.
+GRA-STRING-003 | Warning | (3,0 - 3,24) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/indexof/Constant String - String Int.fs

@@ -1 +1,3 @@
+module M
+
 "foo".IndexOf("p", 0)

tests/data/string/indexof/Constant String - String Int.fs.expected

@@ -1 +1 @@
-GRA-STRING-003 | Warning | (1,0 - 1,21) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.
+GRA-STRING-003 | Warning | (3,0 - 3,21) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/indexof/Function call - Single Argument.fs

@@ -1,2 +1,4 @@
+module M
+
 let f () = "f"
 "g".IndexOf(f())

tests/data/string/indexof/Function call - Single Argument.fs.expected

@@ -1 +1 @@
-GRA-STRING-003 | Warning | (2,0 - 2,16) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.
+GRA-STRING-003 | Warning | (4,0 - 4,16) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/indexof/Prefixed Value - Single Argument.fs

@@ -1,3 +1,5 @@
+module M
+
 module A =
     let b = "b"
 

tests/data/string/indexof/Prefixed Value - Single Argument.fs.expected

@@ -1 +1 @@
-GRA-STRING-003 | Warning | (4,0 - 4,16) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.
+GRA-STRING-003 | Warning | (6,0 - 6,16) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/indexof/Value - Single Argument.fs

@@ -1,2 +1,4 @@
+module M
+
 let a = "a"
 a.IndexOf("a")

tests/data/string/indexof/Value - Single Argument.fs.expected

@@ -1 +1 @@
-GRA-STRING-003 | Warning | (2,0 - 2,14) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.
+GRA-STRING-003 | Warning | (4,0 - 4,14) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/indexof/negative/Char Int32 Int32.fs

@@ -1,2 +1,4 @@
+module M
+
 open System
 "foo".IndexOf('f',0,1)

tests/data/string/indexof/negative/Char Int32.fs

@@ -1,2 +1,4 @@
+module M
+
 open System
 "foo".IndexOf('f',0)

tests/data/string/indexof/negative/Char StringComparison.fs

@@ -1,2 +1,4 @@
+module M
+
 open System
 "foo".IndexOf('f',StringComparison.InvariantCulture)

tests/data/string/indexof/negative/Char.fs

@@ -1,2 +1,4 @@
+module M
+
 open System
 "foo".IndexOf('f')

tests/data/string/indexof/negative/String Int32 Int32 StringComparison.fs

@@ -1,2 +1,4 @@
+module M
+
 open System
 "foo".IndexOf("f",0,1,StringComparison.InvariantCulture)

tests/data/string/indexof/negative/String Int32 StringComparison.fs

@@ -1,2 +1,4 @@
+module M
+
 open System
 "foo".IndexOf("f",0,StringComparison.InvariantCulture)

tests/data/string/indexof/negative/String StringComparison.fs

@@ -1,2 +1,4 @@
+module M
+
 open System
 "foo".IndexOf("f",StringComparison.InvariantCulture)

tests/data/string/startswith/Constant String - Single Argument.fs

@@ -1 +1,3 @@
+module M
+
 "foo".StartsWith("p")

tests/data/string/startswith/Constant String - Single Argument.fs.expected

@@ -1 +1 @@
-GRA-STRING-002 | Warning | (1,0 - 1,21) | The usage of String.StartsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.
+GRA-STRING-002 | Warning | (3,0 - 3,21) | The usage of String.StartsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/startswith/Function call - Single Argument.fs

@@ -1,2 +1,4 @@
+module M
+
 let f () = "f"
 "g".StartsWith(f())

tests/data/string/startswith/Function call - Single Argument.fs.expected

@@ -1 +1 @@
-GRA-STRING-002 | Warning | (2,0 - 2,19) | The usage of String.StartsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.
+GRA-STRING-002 | Warning | (4,0 - 4,19) | The usage of String.StartsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/startswith/Prefixed Value - Single Argument.fs

@@ -1,3 +1,5 @@
+module M
+
 module A =
     let b = "b"
 

tests/data/string/startswith/Prefixed Value - Single Argument.fs.expected

@@ -1 +1 @@
-GRA-STRING-002 | Warning | (4,0 - 4,19) | The usage of String.StartsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.
+GRA-STRING-002 | Warning | (6,0 - 6,19) | The usage of String.StartsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/startswith/Value - Single Argument.fs

@@ -1,2 +1,4 @@
+module M
+
 let a = "a"
 a.StartsWith("a")

tests/data/string/startswith/Value - Single Argument.fs.expected

@@ -1 +1 @@
-GRA-STRING-002 | Warning | (2,0 - 2,17) | The usage of String.StartsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.
+GRA-STRING-002 | Warning | (4,0 - 4,17) | The usage of String.StartsWith with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/startswith/negative/Boolean CultureInfo.fs

@@ -1,3 +1,5 @@
+module M
+
 open System.Globalization    
 
 "a".StartsWith("b", false, CultureInfo.InvariantCulture)

tests/data/string/startswith/negative/Char.fs

@@ -1 +1,3 @@
+module M
+
 "a".StartsWith('b')

tests/data/string/startswith/negative/StringComparison.fs

@@ -1 +1,3 @@
+module M
+
 "a".StartsWith("b", System.StringComparison.InvariantCulture)