[FEATURE] Fix RS0016 errors and enable correct PublicAPI file generation

[MohamedM216]

Description

This PR resolves RS0016 errors by enabling clean Public API generation and separating API files per target framework.

I'm using ubuntu 22.04 and vs code, so I had to change the target framework in Consul.csproj to netstandard2.0 and run dotnet format ./Consul/Consul.csproj --diagnostics RS0016 then change it to net461 and run dotnet format ./Consul/Consul.csproj --diagnostics RS0016. That gave me a correct and clean build and correctly populated PublicAPI.Shipped.txt and PublicAPI.Unshipped.txt files.

Related Issues

#415

Additional Context

Checklist

Please make sure to check the following before submitting your pull request:

• Did you read the contributing guidelines?
• Did you update the docs?
• Did you write any tests to validate this change?

[marcin-krystianc]

In the https://github.com/G-Research/ParquetSharp, we have a common Public.API files and also a framework specific ones. It would be nice if we also have similar structure here, so we avoid most of the duplications.

[MohamedM216]

I'm not sure I fully understand. Could you please explain a bit more?

[marcin-krystianc]

I'm not sure I fully understand. Could you please explain a bit more?

At the moment we have two framework specific API files (Consul/PublicAPI/net461/PublicAPI.Unshipped.txt and Consul/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt)
I guess it is possible to add a new common file (e.g.: Consul/PublicAPI/PublicAPI.Unshipped.txt) and move all common entries into the common file. The framework specific files should contain framework specific entries only (so we avoid duplicating entries)

[MohamedM216]

I updated AdditionalFiles in Consul.csproj to include:

<ItemGroup>
    <AdditionalFiles Include="PublicAPI/PublicAPI.Shipped.txt" />
    <AdditionalFiles Include="PublicAPI/PublicAPI.Unshipped.txt" />
    <AdditionalFiles Include="PublicAPI/$(TargetFramework)/PublicAPI.Shipped.txt" />
    <AdditionalFiles Include="PublicAPI/$(TargetFramework)/PublicAPI.Unshipped.txt" />
  </ItemGroup>

However, it now only populates the common PublicAPI files even when I switch between target frameworks.

[marcin-krystianc]

Nice 👍
Thank you