[FEATURE] Add Microsoft.CodeAnalysis.PublicApiAnalyzers (disabled warnings)

[MohamedM216]

Description

This PR introduces Microsoft.CodeAnalysis.PublicApiAnalyzers to help prevent accidental breaking changes

Related Issues

#415

Additional Context

Checklist

Please make sure to check the following before submitting your pull request:

• Did you read the contributing guidelines?
• Did you update the docs?
• Did you write any tests to validate this change?

[MohamedM216]

Hi @marcin-krystianc, this PR is the first in a series aimed at addressing #415. I would greatly appreciate your guidance and feedback on it. Thanks!

[marcin-krystianc]

Hi @MohamedM216,

thanks for opening the PR. There are some comments, but generally it looks good.

[marcin-krystianc]

I don't think that IncludeAssets is necessary (I know in some blogs this is suggested approach, but as far I know it it is not needed)

Suggested change

<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

[marcin-krystianc]

Unnecessary change, please revert.

[marcin-krystianc]

Let’s use the attribute notation; it is easier to read:

Suggested change

	<PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4">
	<PrivateAssets>all</PrivateAssets>
	</PackageReference>
	<PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4" PrivateAssets="All" />

[marcin-krystianc]

Perfect!
Thank you @MohamedM216

In the next PR try removing the RS0016

[MohamedM216]

Thanks @marcin-krystianc

In the next PR try removing the RS0016

Great, I'm excited to continue with the next steps. And of course, if run into any issues, I'll reach out.