FEATURE: Implement ACL Binding Rule "Read" Endpoint#550
Merged
marcin-krystianc merged 5 commits intoG-Research:masterfrom Jan 27, 2026
Merged
FEATURE: Implement ACL Binding Rule "Read" Endpoint#550marcin-krystianc merged 5 commits intoG-Research:masterfrom
marcin-krystianc merged 5 commits intoG-Research:masterfrom
Conversation
marietta-a
changed the title
Contributor
Author
marcin-krystianc
previously approved these changes
Jan 26, 2026
Contributor
Author
|
@marcin-krystianc I have updated the test |
Consul.Test/BindingRuleTest.cs
Outdated
| await _client.AuthMethod.Create(authMethodEntry); | ||
| var authMethodsResponse = await _client.AuthMethod.List(); | ||
| var existingAuthMethod = authMethodsResponse.Response?.FirstOrDefault(); | ||
| Skip.If(existingAuthMethod == null, "No auth methods available in Consul for testing"); |
Contributor
There was a problem hiding this comment.
Please remove Skip.If and make the test non-skippable by using the [Fact] attribute instead of [SkippableFact]. Since the auth method is created by us, a null auth method should not be expected.
Suggested change
| Skip.If(existingAuthMethod == null, "No auth methods available in Consul for testing"); |
Consul.Test/BindingRuleTest.cs
Outdated
| var authMethodsResponse = await _client.AuthMethod.List(); | ||
| var existingAuthMethod = authMethodsResponse.Response?.FirstOrDefault(); | ||
|
|
||
| Skip.If(existingAuthMethod == null, "No auth methods available in Consul for testing"); |
Contributor
There was a problem hiding this comment.
Suggested change
| Skip.If(existingAuthMethod == null, "No auth methods available in Consul for testing"); |
marcin-krystianc
approved these changes
Jan 27, 2026
Contributor
|
Perfect, thank you! |
This was referenced Jan 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Addresses Issue: #480
Additional Context
Checklist
Please make sure to check the following before submitting your pull request: