Skip to content

FEATURE: Add NodeIdentities Role Attribute#547

Merged
marcin-krystianc merged 5 commits intoG-Research:masterfrom
marietta-a:feat/Role_Attributes_Node_Identity
Jan 21, 2026
Merged

FEATURE: Add NodeIdentities Role Attribute#547
marcin-krystianc merged 5 commits intoG-Research:masterfrom
marietta-a:feat/Role_Attributes_Node_Identity

Conversation

@marietta-a
Copy link
Contributor

@marietta-a marietta-a commented Jan 20, 2026

Description

  • Created NodeIdentity class
  • Added NodeIdentities property to Token and Role classes
  • Added Node Identities to the Constructor of Token and Role classes
  • Created Role and Token tests for Node Identities

Related Issues

Addresses issue #531

Additional Context

Checklist

Please make sure to check the following before submitting your pull request:

  • Did you read the contributing guidelines?
  • Did you update the docs?
  • Did you write any tests to validate this change?

@marietta-a
Copy link
Contributor Author

Hi @marcin-krystianc

@marcin-krystianc
Copy link
Contributor

Hi @marietta-a,

The v1.17.14 tests are failing. The reason is that we explicitly intend to skip serializing NodeIdentities when they are null, but elsewhere we default-initialize them to an empty value.

I think the initialization in the constructor is unnecessary, and the fix for the CI failures should be to revert the Token and Role constructor changes entirely.

@marietta-a
Copy link
Contributor Author

Noted with thanks

@marietta-a
Copy link
Contributor Author

Hi @marcin-krystianc, I removed NodeIdentities initialization from the constructor

Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to update the cut-off version, looks good otherwise!

marietta-a and others added 2 commits January 21, 2026 09:48
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marietta-a Awesome, thank you!

@marcin-krystianc marcin-krystianc merged commit 2e7ebb9 into G-Research:master Jan 21, 2026
119 checks passed
@marietta-a marietta-a deleted the feat/Role_Attributes_Node_Identity branch January 25, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants