Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Support for Getting Service Configuration #278

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Added Support for Getting Service Configuration #278

merged 3 commits into from
Dec 1, 2023

Conversation

sammychinedu2ky
Copy link
Contributor

marcin-krystianc
marcin-krystianc reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more consistent with the rest of the system, to use ServiceId capitalisation.
I know that we have form ``ServiceIDin some classes, but as a parameter in a methodServiceId` form seems more suitable.

@sammychinedu2ky
Copy link
Contributor Author

done

@marcin-krystianc marcin-krystianc merged commit fff5394 into G-Research:master Dec 1, 2023
159 of 160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcin-krystianc marcin-krystianc marcin-krystianc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Getting Service Configuration
2 participants
@sammychinedu2ky @marcin-krystianc