-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Listing and Deleting Configuration Entries #271
Support Listing and Deleting Configuration Entries #271
Conversation
@marcin-krystianc the flaky issue is still occuring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a minor comment about adding two more asserts.
done @marcin-krystianc |
I've found in consul logs this line:
So apparently there is a problem happening on the agent itself (like hashicorp/consul#15061), we probably will need to add some repeats to work around it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
ooh okay thanks. makes sense. We could add a delay though since it is related to early access. |
Fixes #270