Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Listing and Deleting Configuration Entries #271

Merged

Conversation

sammychinedu2ky
Copy link
Contributor

Fixes #270

@sammychinedu2ky
Copy link
Contributor Author

@marcin-krystianc the flaky issue is still occuring

Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor comment about adding two more asserts.

Consul.Test/ConfigurationTest.cs Show resolved Hide resolved
@sammychinedu2ky
Copy link
Contributor Author

done @marcin-krystianc

@marcin-krystianc
Copy link
Contributor

@marcin-krystianc the flaky issue is still occuring

I've found in consul logs this line:

2023-11-23T22:49:26.507Z [ERROR] agent.http: Request error: method=GET url=/v1/agent/metrics from=127.0.0.1:44874 error="json: unsupported value: NaN"

So apparently there is a problem happening on the agent itself (like hashicorp/consul#15061), we probably will need to add some repeats to work around it.

Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@marcin-krystianc marcin-krystianc merged commit 5da7a42 into G-Research:master Nov 24, 2023
160 checks passed
@sammychinedu2ky
Copy link
Contributor Author

@marcin-krystianc the flaky issue is still occuring

I've found in consul logs this line:

2023-11-23T22:49:26.507Z [ERROR] agent.http: Request error: method=GET url=/v1/agent/metrics from=127.0.0.1:44874 error="json: unsupported value: NaN"

So apparently there is a problem happening on the agent itself (like hashicorp/consul#15061), we probably will need to add some repeats to work around it.

ooh okay thanks. makes sense. We could add a delay though since it is related to early access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Listing and Deleting Configuration Entries
3 participants