Added Test for Reload #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
|
Thanks done @marcin-krystianc |
There was a problem hiding this comment.
Hi @sammychinedu2ky,
one more thing. Since we rely on the CONSUL_AGENT_CONFIG_PATH to be set, we need to set it in the CI workflow so the test is actually run 😄
|
Alright 👌 |
.github/workflows/ci.yml
Outdated
| @@ -126,6 +126,7 @@ jobs: | |||
| - name: Run tests | |||
| shell: bash | |||
| run: | | |||
| export CONSUL_AGENT_CONFIG_PATH=$GITHUB_WORKSPACE/Consul.Test/test_config.json | |||
There was a problem hiding this comment.
Instead of using export, you can use env context in line 133
There was a problem hiding this comment.
I switched it now 😄
|
Hi @marcin-krystianc , some test cases passed and some didn't and in some instances it said |
|
Hi @marcin-krystianc please do you know the reason behind that |
|
@marcin-krystianc . I think I would use the skippable feature here |
Makes sense. |
|
done @marcin-krystianc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264
@marcin-krystianc @naskio