Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for agent version #261

Merged
merged 6 commits into from
Nov 29, 2023

Conversation

sammychinedu2ky
Copy link
Contributor

@marcin-krystianc
Copy link
Contributor

Looks good, but there are conflicts to be resolved.

@sammychinedu2ky
Copy link
Contributor Author

@marcin-krystianc . This one also has breaking change across different consul API

@sammychinedu2ky
Copy link
Contributor Author

@marcin-krystianc . I think I would use the skippable feature here

@marcin-krystianc
Copy link
Contributor

@marcin-krystianc . I think I would use the skippable feature here

I think that the problem here is that you didn't specify the json format for output, see https://developer.hashicorp.com/consul/commands/v1.11.x/version#command-options

@sammychinedu2ky
Copy link
Contributor Author

@marcin-krystianc . I think I would use the skippable feature here

I think that the problem here is that you didn't specify the json format for output, see https://developer.hashicorp.com/consul/commands/v1.11.x/version#command-options

Thanks @marcin-krystianc . But that one is for the CLI tool. I am making use of the endpoint
https://developer.hashicorp.com/consul/api-docs/agent#retrieve-version-information

@sammychinedu2ky
Copy link
Contributor Author

done @marcin-krystianc thanks

@marcin-krystianc marcin-krystianc merged commit b28a40a into G-Research:master Nov 29, 2023
160 checks passed
@marcin-krystianc
Copy link
Contributor

Nicely done, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Agent Version Information
3 participants