-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for agent host #259
Added support for agent host #259
Conversation
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
So we are sticking to the set of listed os? |
No, I think it is not a good idea to do it. I forgot to include removal of it in the first patch. |
Okay 👌 |
@marcin-krystianc I've resolved the merge conflict. please can you check it again |
There seems to be some failed test |
Yeah, they look legit. Can you try to investigate what is going on? |
so let me leave it and work on the other code |
I think this change is still worth getting in. I doubt that there will be any major changes in the response body in the future. |
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
I've done that.. once you approve of it, I would work on the merge conflicts |
Ooh cool no conflicts 😄 |
Yeah, it was good to merge. Thank you! |
my pleasure!! |
fixes #258
@marcin-krystianc @naskio