Skip to content

Conversation

@adamreeve
Copy link
Contributor

Looks like setting CMAKE_SYSTEM_PROCESSOR in the older port version caused builds to fail in CI due to microsoft/vcpkg#48496 even though we aren't cross compiling: https://github.com/G-Research/ParquetSharp/actions/runs/19750737197/job/56593190898#step:12:5078

@adamreeve
Copy link
Contributor Author

adamreeve commented Nov 28, 2025

Bumping the port version fixed the Linux native library builds, but the macos-15-intel tests are now failling. There was a runner image update (https://github.com/actions/runner-images/releases/tag/macos-15%2F2025.1126), which includes an XCode update. And it looks like catch (const std::exception& exception) no longer catches a std::out_of_range exception???

Edit: Looks like the default XCode version is 16.4 so I don't think that update is relevant. I'm not sure what has changed to cause this but it still looks related to the runner image update as the tests still fail after reverting vcpkg to the same version used in the last good build. Both builds seem to use the same C++ compiler version (17.0.0.17000013).

@adamreeve
Copy link
Contributor Author

Similar looking issue here indicates we might be linking to the wrong C++ standard library: https://stackoverflow.com/questions/77374525/c-exception-not-caught-on-clang-17-0-3

@adamreeve
Copy link
Contributor Author

I think we should merge this PR to fix the Linux builds and follow up in another issue for the MacOS test failures.

@adamreeve adamreeve marked this pull request as ready for review December 2, 2025 00:52
@marcin-krystianc marcin-krystianc marked this pull request as draft December 3, 2025 11:05
@marcin-krystianc marcin-krystianc marked this pull request as ready for review December 3, 2025 11:23
@adamreeve
Copy link
Contributor Author

Closing, this has been superseded by #599

@adamreeve adamreeve closed this Dec 9, 2025
@adamreeve adamreeve deleted the vcpkg-fix branch December 9, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants