Linux CI builds failing to run vcpkg install

[adamreeve]

See eg. https://github.com/G-Research/ParquetSharp/actions/runs/18477998543/job/52649565755

The runner image and CentOS packages haven't changed, it looks like this is related to changes in vcpkg, probably the ninja update: microsoft/vcpkg@c6935bc

There's a log line about the ninja version being too old:

-- Found ninja('1.13.0.git.kitware.jobserver-pipe-1') but at least version 1.13.1 is required! Trying to use internal version if possible!

[adamreeve]

We install ninja using uv tool install ninja, but the latest ninja version in PyPI is only 1.13.0: https://pypi.org/project/ninja/#history

See scikit-build/ninja-python-distributions#308

It looks like ninja 1.13.1 gets downloaded by vcpkg though, so I'm not sure that this is actually the problem.

[adamreeve]

Error (via tmate) is:

CMake Error at CMakeLists.txt:2 (project):
  Running

   '/usr/local/share/vcpkg/downloads/tools/ninja/1.13.1-linux/ninja' '--version'

  failed with:

   /usr/local/share/vcpkg/downloads/tools/ninja/1.13.1-linux/ninja: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /usr/local/share/vcpkg/downloads/tools/ninja/1.13.1-linux/ninja)

  /usr/local/share/vcpkg/downloads/tools/ninja/1.13.1-linux/ninja:
  /lib64/libstdc++.so.6: version `CXXABI_1.3.8' not found (required by
  /usr/local/share/vcpkg/downloads/tools/ninja/1.13.1-linux/ninja)

  /usr/local/share/vcpkg/downloads/tools/ninja/1.13.1-linux/ninja:
  /lib64/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by
  /usr/local/share/vcpkg/downloads/tools/ninja/1.13.1-linux/ninja)

  /usr/local/share/vcpkg/downloads/tools/ninja/1.13.1-linux/ninja:
  /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by
  /usr/local/share/vcpkg/downloads/tools/ninja/1.13.1-linux/ninja)

It looks like the ninja release builds from GitHub aren't compatible with the older GLIBC in the build container, which I guess is why we installed the one from PyPI.

They are built on rockylinux 8 but we use centos 7: https://github.com/ninja-build/ninja/blob/47ed2d244b8c926bbf8b12bcd1e9204586fcc798/.github/workflows/linux.yml#L55

For some reason, the PyPI builds (https://github.com/scikit-build/ninja-python-distributions) don't use the ninja-build/ninja source, but the Kitware fork, which doesn't have a 1.13.1 release yet: https://github.com/Kitware/ninja/tags

[adamreeve]

Some possible fixes:

• Pin vcpkg version temporarily and hope the Kitware ninja fork and then the scikit-build wheels are updated before we need any new vcpkg changes
• Build ninja ourselves during CI
• Set VCPKG_FORCE_SYSTEM_BINARIES=1
  • This also affects cmake, we might need to install a compatible cmake version
• Change the build image to manylinux_2_28
  • This will drop support for CentOS/RedHat < 8, Ubuntu < 18.10, Debian < 10, Fedora < 29

Looking at these options, setting VCPKG_FORCE_SYSTEM_BINARIES is probably fine but it seems like it might be a good time to update the build image and drop support for some older distributions.

[jgiannuzzi]

I think we should for VCPKG_FORCE_SYSTEM_BINARIES=1. When I introduced the change (#570), I toyed with setting it but it didn't seem necessary. Now I realize that this is because the version that vcpkg wanted to install was lower or equal to the version installed with uv. I'm happy to take care of this as I'm busy with the Windows Arm64 build anyway.