Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dtypes] odML custom tuples are not valid dtypes #254

Closed
mpsonntag opened this issue Mar 19, 2018 · 0 comments
Closed

[dtypes] odML custom tuples are not valid dtypes #254

mpsonntag opened this issue Mar 19, 2018 · 0 comments
Assignees

Comments

@mpsonntag
Copy link
Contributor

mpsonntag commented Mar 19, 2018

Currently the list of supported odML dtypes does not contain odML custom tuples. This has two consequences:

  • odML style tuples can only be created, when creating a new Property, since the dtype is currently not checked during Property init. See also [Property] Init allows invalid dtypes #253. If this should change, odML custom tuples could no longer be created.
  • the dtype of a property cannot be set to an odML custom tuple, since it is not in the list of supported odML dtypes.

Tuple creation example:

p = odml.Property(name="tuple", dtype="2-tuple", value="(12; 12)")

Tuple assignment fail example:

p = odml.Property(name="tupleFail", value="(12; 12)")
p.dtype = "2-tuple"
@mpsonntag mpsonntag self-assigned this Mar 21, 2018
mpsonntag added a commit to mpsonntag/python-odml that referenced this issue Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant