Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean value handling #224

Closed
mpsonntag opened this issue Feb 21, 2018 · 0 comments · Fixed by #233
Closed

Boolean value handling #224

mpsonntag opened this issue Feb 21, 2018 · 0 comments · Fixed by #233

Comments

@mpsonntag
Copy link
Contributor

Currently values "false", "f", False and 0 are automatically converted to boolean False; everything else including any string characters, int and float values are converted to True.

Maybe any value other than "false", "f", 0, False, "true", "t", 1, True should raise a ValueError when trying to assign it to an odML boolean value.
mpsonntag added a commit to mpsonntag/python-odml that referenced this issue Feb 22, 2018
@mpsonntag
[dtypes] Additional dtype bool check
d510fc5 
Closes G-Node#224

Disallow setting a value that cannot be
interpreted as boolean for a boolean DType.
@mpsonntag mpsonntag mentioned this issue Feb 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor package info handling mpsonntag/python-odml
1 participant
@mpsonntag