Skip to content

Frontend tests #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 28, 2020
Merged

Frontend tests #513

merged 11 commits into from
Oct 28, 2020

Conversation

mpsonntag
Copy link
Contributor

@mpsonntag mpsonntag commented Oct 28, 2020 •
edited
Loading

This PR introduces a major rewrite of the frontend selenium tests.

  • it introduces a fix for the conference settings tests where it was possible, that the wrong conference was accessed leading to failing tests.
  • the rewrite also aims to restructure these tests to increase readability and adds comments to make extensive tests more easily understandable.
  • the frontend setup and test documentation is rewritten and now also linked from the main readme document.

The PR also

@mpsonntag
[test/frontend] Fix broken editor references test
06a07ea
@mpsonntag
[test/frontend/editor] Cleanup and description
3b019f2 
The file was refactored for readability and detailled descriptions
were added to clarify which actions are taking place since the
xpath strings make it hard to identify the current action.
@mpsonntag
[readme] Add link to frontend test documentation
abe2c78
@mpsonntag
[views] Add dynamic (c) year
afb0be1
@mpsonntag
[test/frontend] Rewrite readme
fb6af57
@mpsonntag
[test/frontend/editor] Use helper method
90ac3ca 
Use helper method to increase readability
@mpsonntag
[test/frontend/login] Cleanup and description
cc248e0
@mpsonntag
[test/frontend/conferences] Use helper method
c213879
@mpsonntag
[test/frontend/conferences] Test issue fix
0f47e0e 
Switching between conference settings, start page and abstract
and returning to conference settings via xpath lead to access
of other conferences than the intended leading to seemingly
random test fails. Changing the access method of the conference
settings page fixed all test fails.
@mpsonntag
[test/frontend/conferences] Cleanup and desc
3f7641b 
The file was refactored for readability and detailled descriptions
were added to clarify which actions are taking place since the
xpath strings make it hard to identify the current action.
@mpsonntag
Update mathjax version to 2.7.7
9347c10 
Closes G-Node#506
achilleas-k
achilleas-k approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and clean!

@achilleas-k achilleas-k merged commit 759c318 into G-Node:banners Oct 28, 2020
@mpsonntag mpsonntag deleted the frontendTests branch October 28, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achilleas-k achilleas-k achilleas-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpsonntag @achilleas-k