fix(helm-chart): remove always empty name label
#203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `name` label from the deployment which is currently always empty. Also in my case it is breaking the deployment via Argo CD by causing the following error: "failed to set app instance tracking info on manifest: failed to set app instance label: failed to get labels from target object apps/v1, Kind=Deployment /chisel-operator: .metadata.labels accessor error: contains non-string value in the map under key "name": <nil> is of the type <nil>, expected string"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
namelabel from the deployment which is currently always empty.Also in my case it is breaking the deployment via Argo CD by causing the following error: "failed to set app instance tracking info on manifest: failed to set app instance label: failed to get labels from target object apps/v1, Kind=Deployment /chisel-operator: .metadata.labels accessor error: contains non-string value in the map under key "name": is of the type , expected string"