Skip to content

Conversation

@tduhamel42
Copy link
Collaborator

Summary

This PR addresses three main issues:

  1. Fixes live monitoring style error when using --live flag
  2. Removes deprecated volume_mode parameter across the entire codebase
  3. Cleans up duplicate default_parameters in workflow metadata files
  4. Configures Python worker to start automatically with docker compose up

Changes

1. Fixed Live Monitoring Bug

File: cli/src/fuzzforge_cli/commands/workflow_exec.py:456-458

  • Changed from calling Typer command to calling _live_monitor() helper function directly
  • Before: live_monitor(response.run_id, refresh=3) (passed OptionInfo object)
  • After: _live_monitor(response.run_id, refresh=3, once=False, style="inline")
  • Impact: No more "❌ Invalid style: <typer.models.OptionInfo object>" error

2. Removed default_parameters Duplication

Files: 10 workflow metadata.yaml files

  • Removed top-level default_parameters: sections
  • Kept only JSON Schema standard default: fields within parameter definitions
  • Affected workflows: python_sast, llm_secret_detection, trufflehog_detection, security_assessment, ossfuzz_campaign, llm_analysis, gitleaks_detection, cargo_fuzzing, atheris_fuzzing, secret_detection
  • Impact: Cleaner, more standard workflow metadata following JSON Schema conventions

3. Removed Deprecated volume_mode

Files: 26 files across CLI, SDK, backend, AI, and docs

  • CLI (6 files): workflow_exec.py, main.py, validation.py, fuzzy.py, completion.py, constants.py
  • SDK (6 files): client.py, testing.py, 4 example files
  • Backend (3 files): main.py, findings.py, mcp-config.json
  • AI (1 file): agent_executor.py
  • Docs (1 file): CHANGELOG.md
  • Metadata (10 files): All workflow metadata.yaml files
  • Impact: Cleaner codebase without obsolete volume_mode parameter (replaced by MinIO storage)

4. Python Worker Auto-Start

File: docker-compose.yml

  • Removed profiles: section from worker-python service
  • Impact: Python worker (most commonly used) now starts automatically with docker compose up

Testing

Live monitoring tested: ff workflow run python_sast . --live - Works without errors
Workflow execution tested: ff workflow run python_sast . - Works without volume_mode
All functionality verified: No "Volume Mode: ro" in output, live monitoring displays correctly

Impact

  • Breaking changes: None (volume_mode was already deprecated and optional)
  • Performance: Python worker starts automatically, reducing manual intervention
  • User experience: Live monitoring works correctly, cleaner workflow configuration

…uto-start Python worker

- Fix live monitoring style error by calling _live_monitor() helper directly
- Remove default_parameters duplication from 10 workflow metadata files
- Remove deprecated volume_mode parameter from 26 files across CLI, SDK, backend, and docs
- Configure Python worker to start automatically with docker compose up
- Clean up constants, validation, completion, and example files

Fixes #
- Live monitoring now works correctly with --live flag
- Workflow metadata follows JSON Schema standard
- Cleaner codebase without deprecated volume_mode
- Python worker (most commonly used) starts by default
- Remove unused Literal import from backend findings model
- Remove unnecessary f-string prefixes in CLI findings command
- Optimize GitHub Actions to build only modified workers
  - Detect specific worker changes (python, secrets, rust, android, ossfuzz)
  - Build only changed workers instead of all 5
  - Build all workers if docker-compose.yml changes
  - Significantly reduces CI build time
@tduhamel42 tduhamel42 merged commit e180431 into dev Oct 22, 2025
8 checks passed
@tduhamel42 tduhamel42 deleted the fix/cleanup-and-bugs branch October 22, 2025 15:12
tduhamel42 added a commit that referenced this pull request Nov 4, 2025
fix: resolve live monitoring bug, remove deprecated parameters, and auto-start Python worker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants