Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dropdown for postcode radius search on directory service list #425

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Add dropdown for postcode radius search on directory service list #425

wants to merge 7 commits into from

Conversation

chrisrhymes
Copy link
Contributor

@chrisrhymes chrisrhymes commented Mar 5, 2024 •
edited
Loading

  • Add distance dropdown to allow users to change the default radius of 2 miles.
  • Simplify the layout removing hint text, pagination from the top, clear filters button from the top of the filters (as now have Clear search button)
  • Update DropDownSelect component to allow for bold label text and optional hint text.

Testing

  • Checkout this branch and run npm run dev
  • View the Directory Service List component to view the visual changes.

@chrisrhymes chrisrhymes added the enhancement New feature or request label Mar 8, 2024
@chrisrhymes chrisrhymes marked this pull request as ready for review March 8, 2024 10:28
DamienBurkeWN
DamienBurkeWN suggested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@DamienBurkeWN DamienBurkeWN left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropdown isn't defaulting to 2 miles, it's empty.
Dropdown is appearing grey - I'd assumed disabled - but it isn't.
Should dropdown be useable if postcode isn't entered?

src/library/directory/DirectoryServiceList/DirectoryServiceList.tsx Outdated
{ title: '2 miles', value: '2' },
{ title: '5 miles', value: '5' },
{ title: '10 miles', value: '10' },
{ title: '20+ miles', value: '50' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description and limit don't match - should this be a limit of 20 or a limit of 50?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The radius has to be an integer, so setting to 50 to include most of West Northamptonshire.

The new meilisearch will use the _geoRadius method so needs a distance value (the backend will turn the miles into metres.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So shouldn't the title be '50 miles'? As 51 is '20+' but wouldn't be included.

@chrisrhymes chrisrhymes marked this pull request as draft April 3, 2024 09:33
@chrisrhymes
Copy link
Contributor Author

More research and feedback needed for this feature so converting to a draft pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamienBurkeWN DamienBurkeWN DamienBurkeWN requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisrhymes @DamienBurkeWN