Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better BibTeX citekeys #81

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

g-simmons
Copy link

Adds support for Better BibTeX citekeys as discussed in #67.

Changes:

  • add hostname, port, better_bibtex args to ZoteroDB init
  • Make _get_citation_key a method of ZoteroDB
  • If ZoteroDB is initialized with better_bibtex=True, call the Better BibTeX RPC endpoint via the Zotero Connector Integration
  • Add requests to setup.py requirements
  • If this errors, fall back to the default citation keys with a warning
  • If better_bibtex=False, use the default citekey format

@jamesbraza
Copy link
Collaborator

Hi @g-simmons thank you for this PR. We just released v5 today which changes basically the whole repo.

If you are still interested, please rebase this PR atop the current main branch. Also, can you move from requests to httpx

@g-simmons
Copy link
Author

@jamesbraza thanks for the info. I probably won't be able to rebase this any time soon (other time commitments) :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants