Ensuring citation peeks aren't multimodal #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
MicPie,
maykcaldas,
mskarlin,
nadolskit,
sidnarayanan and
whitead
dosubot
bot
added
the
size:XS
|
Related Documentation Checked 1 published document(s). No updates required. How did I do? Any feedback? |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where citation peeks were inadvertently including multimodal content (images) when only text should be used for LLM prompts. The fix ensures citation peeks are text-only by explicitly setting parse_images=False regardless of the global multimodal configuration.
- Explicitly disables image parsing for citation peeks
- Adds memory cleanup by deleting temporary variables after use
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
maykcaldas
approved these changes
Oct 16, 2025
|
Documentation Updates 1 document(s) were updated by changes in this PR How did I do? Any feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized our citation peeks could be multimodal, when we only use the texts in the ensuring LLM prompt.
Having the peek be multimodal was a mistake from #1047