Skip to content

Conversation

@jamesbraza
Copy link
Collaborator

@jamesbraza jamesbraza commented Oct 9, 2025

Accounting for the upstreamings of Future-House/ldp#349

I also created a dev extra for the reader packages, so they can pin latest fhlmi in testing.

@jamesbraza jamesbraza self-assigned this Oct 9, 2025
@jamesbraza jamesbraza added the enhancement New feature or request label Oct 9, 2025
Copilot AI review requested due to automatic review settings October 9, 2025 22:59
@cursor
Copy link

cursor bot commented Oct 9, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on November 5.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves image utility functions from paperqa to the LMI library as part of upstream consolidation efforts. The changes remove image validation and base64 encoding utilities that have been moved to the LMI package.

  • Moved image utility functions (validate_image, bytes_to_string, string_to_bytes) from paperqa.utils to lmi.utils
  • Updated imports to use the new LMI-based utilities
  • Modified the image extra dependency to use fhlmi[image] instead of direct pillow dependency

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/test_paperqa.py Updated imports and removed tests for moved utility functions
src/paperqa/utils.py Removed image validation and base64 conversion functions
src/paperqa/types.py Updated imports and replaced manual image URL encoding with LMI utility
pyproject.toml Changed image extra to depend on fhlmi[image] instead of direct pillow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dosubot
Copy link

dosubot bot commented Oct 9, 2025

Related Documentation

Checked 1 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 10, 2025
@jamesbraza jamesbraza force-pushed the pulling-in-latest-ldp branch from b416e16 to fb30f74 Compare October 14, 2025 22:52
@jamesbraza jamesbraza force-pushed the pulling-in-latest-ldp branch 2 times, most recently from 897ebfb to 247364e Compare October 14, 2025 23:08
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 14, 2025
@jamesbraza jamesbraza force-pushed the pulling-in-latest-ldp branch from 247364e to 42ce067 Compare October 14, 2025 23:13
@jamesbraza jamesbraza merged commit d613594 into main Oct 14, 2025
5 checks passed
@jamesbraza jamesbraza deleted the pulling-in-latest-ldp branch October 14, 2025 23:45
@dosubot
Copy link

dosubot bot commented Oct 14, 2025

Documentation Updates

Checked 1 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants