- 
                Notifications
    You must be signed in to change notification settings 
- Fork 778
Pulling in LMI's image utils #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| You have run out of free Bugbot PR reviews for this billing cycle. This will reset on November 5. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR moves image utility functions from paperqa to the LMI library as part of upstream consolidation efforts. The changes remove image validation and base64 encoding utilities that have been moved to the LMI package.
- Moved image utility functions (validate_image,bytes_to_string,string_to_bytes) from paperqa.utils to lmi.utils
- Updated imports to use the new LMI-based utilities
- Modified the image extra dependency to use fhlmi[image]instead of direct pillow dependency
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description | 
|---|---|
| tests/test_paperqa.py | Updated imports and removed tests for moved utility functions | 
| src/paperqa/utils.py | Removed image validation and base64 conversion functions | 
| src/paperqa/types.py | Updated imports and replaced manual image URL encoding with LMI utility | 
| pyproject.toml | Changed image extra to depend on fhlmi[image] instead of direct pillow | 
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
b416e16    to
    fb30f74      
    Compare
  
    897ebfb    to
    247364e      
    Compare
  
    247364e    to
    42ce067      
    Compare
  
    
Accounting for the upstreamings of Future-House/ldp#349
I also created a
devextra for the reader packages, so they can pin latestfhlmiin testing.