Better lookup failure message in Settings.from_name
#1064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
SamCox822,
maykcaldas,
mskarlin,
nadolskit and
whitead
dosubot
bot
added
the
size:M
There was a problem hiding this comment.
Pull Request Overview
This PR improves error messaging for configuration file lookup failures in Settings.from_name by showing both lookup locations and preventing the clobbering of user config paths when name collisions occur.
- Reorganizes the config file lookup logic to calculate both user and package paths upfront
- Enhances the
FileNotFoundErrormessage to include both the user config path and bundled config path - Fixes the import statement to use the correct module reference
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jamesbraza
force-pushed
the
better-not-found-message
branch
from
80792ce to
839e2da
Compare
jamesbraza
force-pushed
the
better-not-found-message
branch
from
839e2da to
e23583a
Compare
jamesbraza
commented
Aug 16, 2025
| raise FileNotFoundError( | ||
| f"No configuration file found for {config_name}" | ||
| ) from e | ||
| else: |
There was a problem hiding this comment.
Previously without this else we would overwrite the user_config_path location -- @mskarlin does this seem like a bug to you?
jamesbraza
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps with #1044
Now the
FileNotFoundErrorlooks like: