Skip to content

Conversation

@jamesbraza
Copy link
Collaborator

This PR:

  1. Updates journal_quality.py to automatically sync journal_quality.csv
  2. Runs it to sync up journal_quality.csv

Here is a screenshot of the journal_quality.csv diff:

screenshot of journal_quality.csv

@jamesbraza jamesbraza self-assigned this Aug 11, 2025
Copilot AI review requested due to automatic review settings August 11, 2025 21:43
@jamesbraza jamesbraza added the enhancement New feature or request label Aug 11, 2025
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to automatically synchronize the journal_quality.csv file by downloading data from the JUFO portal and processing it to match the expected format. The changes enable the script to be run independently to update the journal quality data.

  • Adds download functionality to fetch journal quality data from JUFO portal
  • Implements CSV processing with progress tracking and override capabilities
  • Includes a main function to orchestrate the download and update process

@whitead
Copy link
Collaborator

whitead commented Aug 11, 2025

Will this have the changes from #1034?

Copy link
Collaborator

@mskarlin mskarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 11, 2025
@jamesbraza jamesbraza force-pushed the journal-quality-script branch from 2be036b to 8717978 Compare August 11, 2025 22:36
@jamesbraza jamesbraza force-pushed the journal-quality-script branch from 8717978 to ef26ad4 Compare August 11, 2025 22:50
@jamesbraza
Copy link
Collaborator Author

Will this have the changes from #1034?

Yeah it does, check the override_allowlist/override_blocklist args in process_csv

@jamesbraza jamesbraza merged commit 4862764 into main Aug 11, 2025
5 checks passed
@jamesbraza jamesbraza deleted the journal-quality-script branch August 11, 2025 23:06
jamesbraza added a commit that referenced this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants