Restored UnpaywallProvider by updating expected response
#1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
SamCox822,
maykcaldas,
mskarlin,
nadolskit and
whitead
dosubot
bot
added
the
size:S
There was a problem hiding this comment.
Pull Request Overview
This PR restores the UnpaywallProvider functionality by updating expected responses to account for API deprecations documented at https://unpaywall.org/data-format. The main changes involve updating test fixtures and test data to reflect the new API response format and different DOI/publication information.
- Updates test data to use a different paper with newer publication details (2025 vs 2024)
- Reorganizes API call sequences in test cassettes to reflect updated Unpaywall responses
- Updates timestamps and response headers in HTTP cassettes to current dates
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_clients.py | Updates test assertions with new paper metadata including DOI, journal, and citation information |
| tests/cassettes/test_doi_search[paper_attributes4].yaml | Reorders API calls and updates response timestamps |
| tests/cassettes/test_doi_search[paper_attributes3].yaml | Updates citation counts and API response timestamps |
| tests/cassettes/test_doi_search[paper_attributes2].yaml | Adds new Unpaywall API call and updates response format |
| tests/cassettes/test_doi_search[paper_attributes1].yaml | Adds Unpaywall API response and updates metadata format |
whitead
approved these changes
Aug 11, 2025
nadolskit
reviewed
Aug 11, 2025
nadolskit
approved these changes
Aug 11, 2025
jamesbraza
force-pushed
the
restoring-unpaywall
branch
from
197e70c to
506fd43
Compare
jamesbraza
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accounting for deprecations from https://unpaywall.org/data-format
Also, updating for "High-throughput screening of human genetic variants by pooled prime editing" having a new 'latest' DOI.