Better invalid name logs #1049
Merged
Better invalid name logs #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
There was a problem hiding this comment.
Pull Request Overview
This PR improves error logging for invalid BibTeX name strings and adds test coverage for issue #1048. The main change enhances the logging message when BibTeX parsing fails by adding the actual exception details and using repr formatting for better readability.
- Enhanced error logging with exception details and repr formatting for titles
- Added new test data for a specific DOI to increase test coverage
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_clients.py | Adds new test case with paper attributes for additional DOI search coverage |
| tests/cassettes/test_doi_search[paper_attributes4].yaml | HTTP response cassette for the new test case containing API responses from multiple services |
| src/paperqa/types.py | Improves error logging by capturing exception details and using repr formatting for better readability |
jamesbraza
force-pushed
the
testing-greek-crash
branch
from
a7d8647 to
f19c8a1
Compare
dosubot
bot
added
size:S
jamesbraza
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also testing #1048