More tests for multi-part

[robotdan]

No description provided.

[bhalsey]

small test suggestion

[bhalsey]

We could catch this exception with the @Test annotation

@Test(expectedExceptions = { ParseException.class })

[spwitt]

I like that it asserts the particular message. It could be rewritten to use JUnit:

ParseException e = assertThrows(
  ParseException.class,
  () -> stream.process(new HashMap<>(), new LinkedList<>())
);
assertEquals(e.getMessage(), "Invalid multipart body. Ran out of data while processing.");

The only real benefit is narrowing the scope of where the exception is thrown, but it's also more testy to write it this way IMO.

[robotdan]

yeah, didn't use the built in because we throw that same exception for several reasons, and wanted to ensure we are throwing the one I expect.

However, I see you can add expectedExceptionsMessageRegExp to the @Test annotation, I could try using that in conjection with expectedExceptions - but maybe same difference at that point.

I'll test it and see if it looks cleaner.

[robotdan]

Looks like it worked, will use it.