Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update saml v2 ui doc #2262

Merged
merged 1 commit into from
Jun 21, 2023
Merged

update saml v2 ui doc #2262

merged 1 commit into from
Jun 21, 2023

Conversation

lyleschemmerling
Copy link
Contributor

No description provided.

mmanes
mmanes approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@mmanes mmanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layout of the inner table seems weird to me. If it is possible to make it span the row, it might look better. Otherwise, LGTM.

@lyleschemmerling lyleschemmerling merged commit 07f199a into master Jun 21, 2023
@lyleschemmerling lyleschemmerling deleted the lyle/saml-idp-init-view-doc-update branch June 21, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmanes mmanes mmanes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyleschemmerling @mmanes