Repository navigation
Integrate GEQDSK vacuum exterior into 1.4 development - #4
Merged
Merged
Conversation
Replace the CHEASE-inspired ray extrapolation with a current-free Grad-Shafranov solve on the rectangular exterior. Preserve the explicit psi_outside override for callers that require a fixed fill value. Protocol: std-commit/1 Contract-Impact: compatible Scientific-Impact: numerical Version-Impact: patch Contract: GEQDSK export defaults to vacuum GS outside the LCFS while retaining psi_outside Validated: ruff check veqpy/model/equilibrium.py tests/test_geqdsk_exterior_topology.py => passed Validated: pytest tests/test_geqdsk_exterior_topology.py -q => 2 passed Qualified-With: distorted LCFS on a 49 x 53 rectangular grid with both flux-span signs Qualified: exterior vacuum GS residual away from cut cells => maximum absolute residual below 2.0e-12 Qualified: far-exterior topology barrier => below 1.0e-6 with closed contours confined to four grid diagonals Reference: v1.3.5 commit 7e19922
Set the source-tree package version to the next minor development line so main cannot be confused with the independently published v1.3.5 artifact. Protocol: std-commit/1 Contract-Impact: none Scientific-Impact: none Version-Impact: minor Validated: ruff check veqpy tests benchmarks demo.py demo_geqdsk.py => passed Validated: pytest -q => 451 passed, 16 skipped, 1 expected warning Validated: python -m compileall -q veqpy tests benchmarks demo.py demo_geqdsk.py => passed Validated: python -m build and twine check => wheel and sdist passed Validated: isolated wheel smoke import => veqpy 1.4.0.dev0 imported outside source tree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
psi_outsidefixed-fill interfacemainas the1.4.0.dev0development line, distinct from the published v1.3.5 maintenance releaseValidation
ruff check veqpy tests benchmarks demo.py demo_geqdsk.pypytest -q— 451 passed, 16 skipped, 1 expected warningpython -m compileall -q veqpy tests benchmarks demo.py demo_geqdsk.pypython -m buildandtwine checkfor wheel and sdistveqpy 1.4.0.dev0outside the source treeNumerical qualification
2.0e-12away from cut cells1.0e-6; closed contours remain in the LCFS collar