Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed the _data_to_plot attribute variable. #3635

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

OceanNuclear
Copy link
Contributor

Linked Issues

Closes #3572

Description

Papercut complete.

Interface Changes

N/A

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@OceanNuclear OceanNuclear requested a review from a team as a code owner October 10, 2024 19:17
Copy link

sonarcloud bot commented Oct 10, 2024

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.37%. Comparing base (d330bcd) to head (41773ff).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3635   +/-   ##
========================================
  Coverage    76.37%   76.37%           
========================================
  Files          230      230           
  Lines        26710    26710           
========================================
  Hits         20401    20401           
  Misses        6309     6309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@je-cook je-cook self-assigned this Oct 11, 2024
Copy link
Contributor

@je-cook je-cook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@je-cook je-cook merged commit ddc4d70 into develop Oct 11, 2024
11 checks passed
@je-cook je-cook deleted the ocean/pc-plotter-rename branch October 11, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Probably better to rename self._data_to_plot into self._projected_data or self._data2d
2 participants