Lao polynomial fixes #3634
Merged
Lao polynomial fixes #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialRight. Saved in here so that we can re-access in the git history.
…he text is also referring to a non-existent section ('in the following'), so I've removed that as well.
…, so that we don't end up confusingly triply-defining the same function (g(psi,alpha)).
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3634 +/- ##
===========================================
+ Coverage 76.37% 76.39% +0.01%
===========================================
Files 230 230
Lines 26710 26710
===========================================
+ Hits 20401 20406 +5
+ Misses 6309 6304 -5 ☔ View full report in Codecov by Sentry. |
je-cook
added
bug
|
For Matti's benefit/to save some compile time, this is a screenshot of the HTML file created by sphinx corresponding to the .rst file that I changed: |
CoronelBuendia
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #3625
Description
Fixed all issues related to Lao polynomials, including both Documentation and Implementation. Clarified the documentation as well.
Interface Changes
N/A
Checklist
I confirm that I have completed the following checks:
pytestfortests/equilibria/test_equilibrium.pyandtests/equilibria/fem_fixed_boundary/test_fem_magnetostatic_2D.pypre-commit run --from-ref develop --to-ref HEADsphinx-build -W documentation/source documentation/build📚 Documentation preview 📚: https://bluemira--3634.org.readthedocs.build/en/3634/