-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Logging cleanup #3614
🎨 Logging cleanup #3614
Conversation
8e57918
to
91e5102
Compare
91e5102
to
9b1693d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3614 +/- ##
===========================================
+ Coverage 76.38% 76.42% +0.03%
===========================================
Files 230 230
Lines 26677 26721 +44
===========================================
+ Hits 20378 20422 +44
Misses 6299 6299 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup
I've rearranged some things here so the comment dont really fit could you have another look? |
7e85fbb
to
dd07ada
Compare
dd07ada
to
40e40d9
Compare
70b08e9
to
d1ae538
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah lgtm
Description
Moves some logging mechanics to a lower level so it is collated, some work towards #3399
Interface Changes
Checklist
I confirm that I have completed the following checks:
pytest tests --reactor
pre-commit run --from-ref develop --to-ref HEAD
sphinx-build -W documentation/source documentation/build