Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option to configure the confinement time in RadiationSource #3506

Conversation

kj5248
Copy link
Contributor

@kj5248 kj5248 commented Aug 9, 2024

Linked Issues

Closes #3466

Description

Allowed for confinement time to vary from value of 0.1 ms in RadiationSource

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@kj5248 kj5248 requested a review from a team as a code owner August 9, 2024 08:31
@kj5248 kj5248 linked an issue Aug 9, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Aug 9, 2024

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.37%. Comparing base (3b83ac6) to head (9c42e29).
Report is 47 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3506   +/-   ##
========================================
  Coverage    76.37%   76.37%           
========================================
  Files          230      230           
  Lines        26632    26632           
========================================
  Hits         20341    20341           
  Misses        6291     6291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 9, 2024

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (7)

On collect

  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/ufl_type.py:56: DeprecationWarning: attach_operators_from_hash_data deprecated, please use UFLObject instead.

On runtest

  • /home/runner/work/bluemira/bluemira/bluemira/equilibria/optimisation/harmonics/harmonics_approx_functions.py:41: RuntimeWarning: divide by zero encountered in log10
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/basix/ufl.py:1909: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:23: DeprecationWarning: Use of elements created by UFL is deprecated. You should create elements directly using Basix.
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:26: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/expr.py:275: DeprecationWarning: Expr.ufl_domain() is deprecated, please use extract_unique_domain(expr) instead.
  • /home/runner/work/bluemira/bluemira/bluemira/radiation_transport/radiation_tools.py:719: DeprecationWarning: interp2dis deprecated!interp2d` is deprecated in SciPy 1.10 and will be removed in SciPy 1.12.0.

For legacy code, nearly bug-for-bug compatible replacements are
RectBivariateSpline on regular grids, and bisplrep/bisplev for
scattered 2D data.

In new code, for regular grids use RegularGridInterpolator instead.
For scattered data, prefer LinearNDInterpolator or
CloughTocher2DInterpolator.

For more details see
https://gist.github.com/ev-br/8544371b40f414b7eaf3fe6217209bff
`

@je-cook je-cook self-assigned this Aug 9, 2024
@je-cook je-cook added the radiation_transport Tasks relating to radiation transport label Aug 9, 2024
@je-cook je-cook merged commit 18ec8bb into develop Aug 9, 2024
10 checks passed
@je-cook je-cook deleted the jmatthews/3466-pass-confinement-time-into-radiation-source-class branch August 9, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
radiation_transport Tasks relating to radiation transport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass confinement time into Radiation source class
2 participants