Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ CI fix #3475

Merged
merged 4 commits into from
Jul 29, 2024
Merged

⚗️ CI fix #3475

merged 4 commits into from
Jul 29, 2024

Conversation

je-cook
Copy link
Contributor

@je-cook je-cook commented Jul 29, 2024

Description

Some dependency has changed since friday (26/07/24), the CI now fails

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook added the continuous_integration Tasks relating to the CI infrastructure and workflows label Jul 29, 2024
@je-cook je-cook added the dependencies Pull requests that update a dependency file label Jul 29, 2024
@je-cook
Copy link
Contributor Author

je-cook commented Jul 29, 2024

test 2 seems like the winner so far...

This reverts commit 02a6b60.
Copy link

sonarcloud bot commented Jul 29, 2024

@je-cook je-cook marked this pull request as ready for review July 29, 2024 07:56
@je-cook je-cook requested a review from a team as a code owner July 29, 2024 07:56
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.58%. Comparing base (0f891a2) to head (983d320).
Report is 55 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3475   +/-   ##
========================================
  Coverage    74.58%   74.58%           
========================================
  Files          231      231           
  Lines        26875    26875           
========================================
  Hits         20046    20046           
  Misses        6829     6829           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

⚠️ Warning Report

Found 5 warnings.

All warnings (5)

On runtest

  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/basix/ufl.py:1909: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:26: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/expr.py:275: DeprecationWarning: Expr.ufl_domain() is deprecated, please use extract_unique_domain(expr) instead.
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:23: DeprecationWarning: Use of elements created by UFL is deprecated. You should create elements directly using Basix.

On collect

  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/ufl_type.py:56: DeprecationWarning: attach_operators_from_hash_data deprecated, please use UFLObject instead.

@oliverfunk oliverfunk merged commit a01a038 into develop Jul 29, 2024
7 of 8 checks passed
@oliverfunk oliverfunk deleted the je-cook/ci_pin branch July 29, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous_integration Tasks relating to the CI infrastructure and workflows dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants