Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix sonarcloud quality bug #3450

Merged
merged 1 commit into from
Jul 15, 2024
Merged

🐛 Fix sonarcloud quality bug #3450

merged 1 commit into from
Jul 15, 2024

Conversation

je-cook
Copy link
Contributor

@je-cook je-cook commented Jul 15, 2024

Description

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook added the bug Something isn't working label Jul 15, 2024
@je-cook je-cook requested a review from a team as a code owner July 15, 2024 10:26
Copy link

sonarcloud bot commented Jul 15, 2024

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62%. Comparing base (2c3908a) to head (d985319).
Report is 52 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3450   +/-   ##
========================================
  Coverage    74.62%   74.62%           
========================================
  Files          231      231           
  Lines        26838    26838           
========================================
  Hits         20027    20027           
  Misses        6811     6811           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliverfunk oliverfunk merged commit 06ccfa3 into develop Jul 15, 2024
7 of 8 checks passed
@oliverfunk oliverfunk deleted the je-cook/fix_sc_qual branch July 15, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants