Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilterMaterial typing fix #3434

Merged
merged 1 commit into from
Jul 11, 2024
Merged

FilterMaterial typing fix #3434

merged 1 commit into from
Jul 11, 2024

Conversation

oliverfunk
Copy link
Contributor

Linked Issues

Closes #{ID}

Description

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@oliverfunk oliverfunk requested a review from a team as a code owner July 11, 2024 12:35
@oliverfunk oliverfunk assigned oliverfunk and je-cook and unassigned oliverfunk Jul 11, 2024
Copy link

sonarcloud bot commented Jul 11, 2024

@je-cook je-cook added the quality Tasks relating to quality issues or improvements label Jul 11, 2024
@je-cook je-cook enabled auto-merge (squash) July 11, 2024 12:41
@je-cook je-cook merged commit f7b1773 into develop Jul 11, 2024
5 of 6 checks passed
@je-cook je-cook deleted the oliverfunk/filter-mat-lint-fix branch July 11, 2024 12:46
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.56%. Comparing base (504f296) to head (7b9b0e2).
Report is 53 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3434      +/-   ##
===========================================
- Coverage    74.58%   74.56%   -0.02%     
===========================================
  Files          231      231              
  Lines        26812    26812              
===========================================
- Hits         19998    19993       -5     
- Misses        6814     6819       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Tasks relating to quality issues or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants