Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix radiation transport tests #3289

Merged
merged 1 commit into from
May 20, 2024

Conversation

je-cook
Copy link
Contributor

@je-cook je-cook commented May 20, 2024

Description

In #3265 I think this small change was missed.

Interface Changes

None

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook added bug Something isn't working radiation_transport Tasks relating to radiation transport labels May 20, 2024
@je-cook je-cook requested a review from a team as a code owner May 20, 2024 10:33
@je-cook je-cook force-pushed the je-cook/fix-radiation_transport branch from db054a7 to de5df16 Compare May 20, 2024 10:34
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.28%. Comparing base (4cf0a96) to head (de5df16).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3289      +/-   ##
===========================================
+ Coverage    74.25%   74.28%   +0.02%     
===========================================
  Files          242      242              
  Lines        26822    26821       -1     
===========================================
+ Hits         19918    19923       +5     
+ Misses        6904     6898       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (5)

On runtest

  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/basix/ufl.py:1909: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/expr.py:275: DeprecationWarning: Expr.ufl_domain() is deprecated, please use extract_unique_domain(expr) instead.
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:23: DeprecationWarning: Use of elements created by UFL is deprecated. You should create elements directly using Basix.
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:26: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead

On collect

  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/ufl_type.py:56: DeprecationWarning: attach_operators_from_hash_data deprecated, please use UFLObject instead.

@oliverfunk oliverfunk merged commit fe51d08 into develop May 20, 2024
7 checks passed
@oliverfunk oliverfunk deleted the je-cook/fix-radiation_transport branch May 20, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working radiation_transport Tasks relating to radiation transport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants