Remove some repetition from Greens

[geograham]

Linked Issues

Papercut #205 - three suggestions are made in this issue. The first addresses repetition and is covered by this pull request. The second is now a separate issue (#3273). The third was discussed by Bluemira developers but does not need to be implemented.

Description

Calculations that are repeated in multiple locations are now functions.

Checklist

I confirm that I have completed the following checks:

• Tests run locally and pass pytest tests --reactor
• Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
• Documentation built locally and checked sphinx-build -W documentation/source documentation/build

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.7% Duplication on New Code

See analysis details on SonarCloud

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.02%. Comparing base (b5b5b3f) to head (bd8b76f).
Report is 41 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3272      +/-   ##
===========================================
- Coverage    76.38%   76.02%   -0.36%     
===========================================
  Files          230      230              
  Lines        26640    26640              
===========================================
- Hits         20349    20254      -95     
- Misses        6291     6386      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (7)

On runtest

• /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:26: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead
• /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:23: DeprecationWarning: Use of elements created by UFL is deprecated. You should create elements directly using Basix.
• /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/basix/ufl.py:1909: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead
• /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/expr.py:275: DeprecationWarning: Expr.ufl_domain() is deprecated, please use extract_unique_domain(expr) instead.
• /home/runner/work/bluemira/bluemira/bluemira/equilibria/optimisation/harmonics/harmonics_approx_functions.py:41: RuntimeWarning: divide by zero encountered in log10
• /home/runner/work/bluemira/bluemira/bluemira/radiation_transport/radiation_tools.py:731: DeprecationWarning: interp2dis deprecated!interp2d` is deprecated in SciPy 1.10 and will be removed in SciPy 1.12.0.

For legacy code, nearly bug-for-bug compatible replacements are
RectBivariateSpline on regular grids, and bisplrep/bisplev for
scattered 2D data.

In new code, for regular grids use RegularGridInterpolator instead.
For scattered data, prefer LinearNDInterpolator or
CloughTocher2DInterpolator.

For more details see
https://gist.github.com/ev-br/8544371b40f414b7eaf3fe6217209bff
`

On collect

• /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/ufl_type.py:56: DeprecationWarning: attach_operators_from_hash_data deprecated, please use UFLObject instead.