Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Hacky fix for CAD rotation saving bug #3235

Merged
merged 1 commit into from
Apr 30, 2024
Merged

🐛 Hacky fix for CAD rotation saving bug #3235

merged 1 commit into from
Apr 30, 2024

Conversation

je-cook
Copy link
Contributor

@je-cook je-cook commented Apr 30, 2024

Linked Issues

Closes #3192

Description

This is the easy fix for saving the CAD on the correct plane, should do some

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook requested a review from a team as a code owner April 30, 2024 12:26
@je-cook je-cook added bug Something isn't working cad Tasks relating to the cad module labels Apr 30, 2024
@oliverfunk oliverfunk enabled auto-merge (squash) April 30, 2024 12:27
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@oliverfunk oliverfunk merged commit 4eb7987 into develop Apr 30, 2024
5 checks passed
@oliverfunk oliverfunk deleted the je-cook/cad_rotation_fix branch April 30, 2024 12:37
@je-cook je-cook mentioned this pull request Apr 30, 2024
Open
OceanNuclear pushed a commit that referenced this pull request Jun 17, 2024
@je-cook @OceanNuclear
🐛 Hacky fix for CAD rotation saving bug (#3235)
82b6f28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfunk oliverfunk oliverfunk approved these changes

Assignees

@oliverfunk oliverfunk

Labels
bug Something isn't working cad Tasks relating to the cad module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Saved CAD lies on XY plane instead of XZ
2 participants
@je-cook @oliverfunk