Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix 3 #3191

Merged
merged 3 commits into from
Apr 17, 2024
Merged

CI fix 3 #3191

merged 3 commits into from
Apr 17, 2024

Conversation

oliverfunk
Copy link
Contributor

Linked Issues

Closes #{ID}

Description

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@oliverfunk oliverfunk requested a review from a team as a code owner April 17, 2024 14:50
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.71%. Comparing base (ac089e1) to head (74be01c).
Report is 1 commits behind head on develop.

❗ Current head 74be01c differs from pull request most recent head 5b6fff2. Consider uploading reports for the commit 5b6fff2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3191   +/-   ##
========================================
  Coverage    82.71%   82.71%           
========================================
  Files          218      218           
  Lines        23587    23587           
========================================
  Hits         19509    19509           
  Misses        4078     4078           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@oliverfunk oliverfunk enabled auto-merge (squash) April 17, 2024 15:19
@oliverfunk oliverfunk merged commit 33af0a7 into develop Apr 17, 2024
4 of 5 checks passed
@oliverfunk oliverfunk deleted the oliverfunk/ci-fork-fix-3 branch April 17, 2024 15:25
OceanNuclear pushed a commit that referenced this pull request Jun 17, 2024
* changed string check

* adding back fork

* dumb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants