Add functionality for uneven endcaps polyhedral current source #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3153 +/- ##
===========================================
+ Coverage 80.46% 80.49% +0.03%
===========================================
Files 222 222
Lines 24644 24661 +17
===========================================
+ Hits 19829 19851 +22
+ Misses 4815 4810 -5 ☔ View full report in Codecov by Sentry. |
kj5248
force-pushed
the
jmatthews/add-functionality-for-uneven-endcaps-polyhedral-current-source
branch
from
f850710
to
e3b4e65
Compare
kj5248
force-pushed
the
jmatthews/add-functionality-for-uneven-endcaps-polyhedral-current-source
branch
from
e3b4e65
to
c6ad8c6
Compare
|
kj5248
commented
Apr 25, 2024
je-cook
approved these changes
May 9, 2024
je-cook
deleted the
jmatthews/add-functionality-for-uneven-endcaps-polyhedral-current-source
branch
OceanNuclear
pushed a commit
that referenced
this pull request
Jun 17, 2024
* initial changes, needs refinement * added singular warning when using circuits * small fix of var name * fix to attribute error * comment out section * change to warning calling method * made bool inputs optional for polyhedralprismcurrentsource * added and changed tests that involve polyhedralprismcurrentsource end cap angles * discretize to discretise fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding functionality to allow for ArbitraryPlanarPolyhedralXSCircuit to work when PolyhedralPrismCurrentSource has non equal end cap angles. Ideally a way to do it such that it is obvious when done and has to be intentional. Likely add a warning when used for this effect and to point out that there is reduction in accuracy of result when doing this. For use in STEP bluemira so can have TF coils with non-rectangular cross sections.
Checklist
I confirm that I have completed the following checks:
pytest tests --reactorpre-commit run --from-ref develop --to-ref HEADsphinx-build -W documentation/source documentation/build