✨ Add more labels for Geometry Parameterisations

[je-cook]

Linked Issues

Closes #1747 (well as many as is reasonable)

Description

Add some of the missing labels to our geometry parameterisations

Interface Changes

Checklist

I confirm that I have completed the following checks:

• Tests run locally and pass pytest tests --reactor
• Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
• Documentation built locally and checked sphinx-build -W documentation/source documentation/build

[github-actions]

⚠️ Warning Report

Found 21 warnings.

All warnings (21)

On runtest

• /home/runner/work/bluemira/bluemira/tests/builders/test_tf_coils.py:46: DeprecationWarning: RippleConstrainedLengthGOP API has changed, please specify how you want to constrain TF ripple by using one of the available RipplePointSelector classes. Defaulting to an EquispacedSelector with n_rip_points=3 for now.
• /home/runner/work/bluemira/bluemira/tests/equilibria/test_file.py:181: TypeHintWarning: Skipping type check against 'float'; this looks like a string-form forward reference imported from another module
• /home/runner/work/bluemira/bluemira/tests/equilibria/test_file.py:181: TypeHintWarning: Skipping type check against 'Optional[str]'; this looks like a string-form forward reference imported from another module
• /home/runner/work/bluemira/bluemira/bluemira/base/reactor.py:677: DeprecationWarning: Using kwarg 'dim' is no longer supported. Simply pass in the dimensions you would like to show, e.g. show_cad('xz')
• /home/runner/work/bluemira/bluemira/tests/equilibria/test_file.py:181: TypeHintWarning: Skipping type check against 'npt.NDArray[np.float64]'; this looks like a string-form forward reference imported from another module
• /home/runner/work/bluemira/bluemira/eudemo/eudemo/tf_coils/tf_coils.py:338: DeprecationWarning: Argument 'separatrix' is deprecated, argument 'ripple_wire' is used instead.
• /home/runner/work/bluemira/bluemira/tests/equilibria/test_file.py:181: TypeHintWarning: Skipping type check against 'str'; this looks like a string-form forward reference imported from another module
• /home/runner/work/bluemira/bluemira/tests/equilibria/test_file.py:181: TypeHintWarning: Skipping type check against 'Optional[npt.NDArray[np.float64]]'; this looks like a string-form forward reference imported from another module
• /home/runner/miniconda3/envs/bluemira/lib/python3.8/site-packages/h5py/__init__.py:36: UserWarning: h5py is running against HDF5 1.14.3 when it was built against 1.14.2, this may cause problems
• /home/runner/work/bluemira/bluemira/tests/equilibria/test_file.py:181: TypeHintWarning: Skipping type check against 'int'; this looks like a string-form forward reference imported from another module

On collect

• /home/runner/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.utilities.opt_tools' is deprecated and will be removed in v2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.
• /home/runner/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.equilibria.opt_constraints' is deprecated and will be removed in v2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.
• /home/runner/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.utilities.optimiser' is deprecated and will be removed in version 2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.
• /home/runner/miniconda3/envs/bluemira/lib/python3.8/site-packages/pkg_resources/__init__.py:2832: DeprecationWarning: Deprecated call to pkg_resources.declare_namespace('mpl_toolkits'). Implementing implicit namespace packages (as specified in PEP 420) is preferred to pkg_resources.declare_namespace. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
• /home/runner/miniconda3/envs/bluemira/lib/python3.8/site-packages/pkg_resources/__init__.py:2832: DeprecationWarning: Deprecated call to pkg_resources.declare_namespace('sphinxcontrib'). Implementing implicit namespace packages (as specified in PEP 420) is preferred to pkg_resources.declare_namespace. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
• /home/runner/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.equilibria.opt_objectives' is deprecated and will be removed in v2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.
• /home/runner/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
• /home/runner/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.geometry.optimisation._optimisation_old' is deprecated and will be removed in v2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.
• /home/runner/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.equilibria.opt_problems' is deprecated and will be removed in v2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.
• /home/runner/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.equilibria.opt_constraint_funcs' is deprecated and will be removed in v2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.
• /home/runner/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.utilities.opt_problems' is deprecated and will be removed in v2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.

[codecov]

Codecov Report

Attention: Patch coverage is 62.50000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 79.71%. Comparing base (d21b53a) to head (2db5691).
Report is 1 commits behind head on develop.

❗ Current head 2db5691 differs from pull request most recent head 7177fd3. Consider uploading reports for the commit 7177fd3 to get more accurate results

Files	Patch %	Lines
bluemira/geometry/parameterisations.py	62.50%	21 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3081      +/-   ##
===========================================
- Coverage    79.77%   79.71%   -0.06%     
===========================================
  Files          227      227              
  Lines        25478    25512      +34     
===========================================
+ Hits         20324    20337      +13     
- Misses        5154     5175      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[oliverfunk]

Yeah LGTM!

This is a proper nit, but I don't like the double arrows used (personally)

On line 319, I would change arrowstyle to

"arrowstyle": "<|-",

[sonarcloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud