Fix incorrect application of EPS (Papercut/ issue #1084) #3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
je-cook
force-pushed
the
papercut/1084
branch
from
9142752
to
4e63840
Compare
…fixed the bug that caused the Interpolator's geometry to be considered infeasible (accidentally set the threshold too tight when the atol=0 overrode the default tolerance.).
je-cook
force-pushed
the
papercut/1084
branch
from
4e63840
to
20e475b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3000 +/- ##
========================================
Coverage 79.79% 79.79%
========================================
Files 226 226
Lines 25120 25122 +2
========================================
+ Hits 20045 20047 +2
Misses 5075 5075 ☔ View full report in Codecov by Sentry. |
je-cook
reviewed
Feb 12, 2024
|
je-cook
approved these changes
Feb 16, 2024
OceanNuclear
added a commit
that referenced
this pull request
Feb 20, 2024
* Fixed all of the places where EPS may be incorrectly applied * Fixed all places where EPS is used in atol instead of rtol incorrectly. * Moved the EPS_FREECAD constant to geometry.constants; Identified and fixed the bug that caused the Interpolator's geometry to be considered infeasible (accidentally set the threshold too tight when the atol=0 overrode the default tolerance.). * Increased test coverage * Removed optimize.bisect and found an analytical solution using arctan instead. * ruff check * Corrected tolerance value to D_TOLERANCE, and added test coverage. * deleted debugging print statement * Minor edit to comments in geometry.constants * Finished papercut.
OceanNuclear
added a commit
that referenced
this pull request
Jun 17, 2024
* Fixed all of the places where EPS may be incorrectly applied * Fixed all places where EPS is used in atol instead of rtol incorrectly. * Moved the EPS_FREECAD constant to geometry.constants; Identified and fixed the bug that caused the Interpolator's geometry to be considered infeasible (accidentally set the threshold too tight when the atol=0 overrode the default tolerance.). * Increased test coverage * Removed optimize.bisect and found an analytical solution using arctan instead. * ruff check * Corrected tolerance value to D_TOLERANCE, and added test coverage. * deleted debugging print statement * Minor edit to comments in geometry.constants * Finished papercut.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #1084
Description
Since floating point numbers isn't a dense representation of the real number line (it's sparse, but "denser" toward the center:
)
We have to consider that the "resolution" varies with the value of the float, i.e. the step size increases wrt. abs value of float.
Interface Changes
Added a variable called "EPS_FREECAD" which would be used in place of EPS whenever geometry is involved.
Checklist
I confirm that I have completed the following checks:
pytest tests --reactorpre-commit run --from-ref develop --to-ref HEADsphinx-build -W documentation/source documentation/build