Collate random seed setting #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athoynilimanew
force-pushed
the
anilima/2960-collate-random-seed-setting
branch
from
ddcfc03
to
f01f07e
Compare
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2978 +/- ##
===========================================
+ Coverage 79.79% 79.81% +0.01%
===========================================
Files 226 226
Lines 25044 25052 +8
===========================================
+ Hits 19985 19994 +9
+ Misses 5059 5058 -1 ☔ View full report in Codecov by Sentry. |
|
|
|
athoynilimanew
changed the title
athoynilimanew
changed the title
je-cook
approved these changes
Jan 31, 2024
OceanNuclear
pushed a commit
that referenced
this pull request
Feb 20, 2024
* 🔐 Collate random seed setting * ✅ Add random seed from RNGSeeds class to the function in collocation_points() --------- Co-authored-by: Athoy Nilima <athoy.nilima@ukaea.uk>
OceanNuclear
pushed a commit
that referenced
this pull request
Jun 17, 2024
* 🔐 Collate random seed setting * ✅ Add random seed from RNGSeeds class to the function in collocation_points() --------- Co-authored-by: Athoy Nilima <athoy.nilima@ukaea.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #2960
Description
Collate random seed setting: sets the random number seed so our results in some cases are reproduceable.
Added the class
RNGSeedsinbluemira/base/constants.py.It sets random seeds to be used in functions that depend on random number generations:
collocation_points()inbluemira.equilibria.harmonics,generate_lognorm_distribution(),generate_truncnorm_distribution(), andgenerate_exponential_distribution()inbluemira.fuel_cycle.timeline_tools,and
calculate_outages()inbluemira.fuel_cycle.timelineIn case you add new functionalities in Bluemira in future that would depend on random number generations, it will be suggested to put a corresponding random seed in the
RNGSeedsclass too.Interface Changes
Checklist
I confirm that I have completed the following checks:
pytest tests --reactorpre-commit run --from-ref develop --to-ref HEADsphinx-build -W documentation/source documentation/build