Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Update process install script and fixup associated files #1983

Closed
wants to merge 3 commits into from

Conversation

je-cook
Copy link
Contributor

@je-cook je-cook commented Mar 1, 2023

Linked Issues

part of #1685 specifically #1685 (comment)

Description

The process install script hack seems to no longer be needed on WSL and it was never needed on pure linux. I've updated the script and update some docs around it.

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass flake8 and black .
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook requested review from a team as code owners March 1, 2023 11:32
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #1983 (02f926c) into develop (6646257) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1983      +/-   ##
===========================================
- Coverage    79.22%   79.21%   -0.02%     
===========================================
  Files          188      188              
  Lines        21661    21661              
===========================================
- Hits         17161    17158       -3     
- Misses        4500     4503       +3     

see 2 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (3)

On runtest

  • /home/runner/work/bluemira/bluemira/bluemira/base/reactor.py:162: DeprecationWarning: Using kwarg 'dim' is no longer supported. Simply pass in the dimensions you would like to show, e.g. show_cad('xz')
  • /home/runner/work/bluemira/bluemira/bluemira/builders/tf_coils.py:624: DeprecationWarning: RippleConstrainedLengthGOP API has changed, please specify how you want to constrain TF ripple by using one of the available RipplePointSelector classes. Defaulting to an EquispacedSelector with n_rip_points=3 for now.
  • /home/runner/work/bluemira/bluemira/bluemira/builders/tf_coils.py:624: DeprecationWarning: RippleConstrainedLengthGOP API has changed, please specify how you want to constrain TF ripple by using one of the available RipplePointSelector classes. Defaulting to an EquispacedSelector with n_rip_points=100 for now.

@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@je-cook je-cook marked this pull request as draft March 2, 2023 10:59
@je-cook
Copy link
Contributor Author

je-cook commented Mar 2, 2023

the python version doesnt yet seem to be picked up by process

@je-cook je-cook mentioned this pull request Mar 13, 2023
3 tasks
@je-cook je-cook force-pushed the je-cook/update_process_script branch from ccf3fc9 to 02f926c Compare June 26, 2023 09:49
@sonarcloud
Copy link

sonarcloud bot commented Jun 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@je-cook
Copy link
Contributor Author

je-cook commented Sep 26, 2023

superceeded by #2522 and #2616

@je-cook je-cook closed this Sep 26, 2023
@je-cook je-cook deleted the je-cook/update_process_script branch September 28, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants