-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Update process install script and fixup associated files #1983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1983 +/- ##
===========================================
- Coverage 79.22% 79.21% -0.02%
===========================================
Files 188 188
Lines 21661 21661
===========================================
- Hits 17161 17158 -3
- Misses 4500 4503 +3 |
|
Kudos, SonarCloud Quality Gate passed! |
the python version doesnt yet seem to be picked up by process |
3 tasks
The hack is no longer required for the process install and fixup some docs stuff
je-cook
force-pushed
the
je-cook/update_process_script
branch
from
June 26, 2023 09:49
ccf3fc9
to
02f926c
Compare
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
part of #1685 specifically #1685 (comment)
Description
The process install script hack seems to no longer be needed on WSL and it was never needed on pure linux. I've updated the script and update some docs around it.
Interface Changes
Checklist
I confirm that I have completed the following checks:
pytest tests --reactor
flake8
andblack .
sphinx-build -W documentation/source documentation/build