Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Model switches and Variables in bluemira.codes.process #3030

Closed
athoynilimanew opened this issue Feb 19, 2024 · 0 comments · Fixed by #3031
Closed

Missing Model switches and Variables in bluemira.codes.process #3030

athoynilimanew opened this issue Feb 19, 2024 · 0 comments · Fixed by #3031
Labels
bug Something isn't working

Comments

@athoynilimanew
Copy link
Contributor

athoynilimanew commented Feb 19, 2024 •
edited
Loading

Describe the bug

The following switches are missing in bluemira.codes.process.model_mapping:

  • ipump(Switch for whether the FW and BB are on the same pump system)
  • fwcoolant(switch for first wall coolant)
  • iblanket(switch for blanket model)
  • iblnkith(switch for inboard blanket)
  • ims(switch for multi/single module segment)
  • i_bb_liq(switch for liquid metal breeder material)
  • icooldual(switch to specify whether breeding blanket is single-cooled or dual coolant)
  • ifci (switch for flow channel Insert type if liquid metal breeder blanket)

Also missing the Scan Variable functionality: scan_dim

Steps to reproduce

with template_builder = PROCESSTemplateBuilder(), Try to use template_builder.set_model() or template_builder.add variable() to set the above switches/variables

Expected behaviour

You will get error that the above model switches/variables does not exist/are not known

Screenshots / Tracebacks

N/A

Environment (please complete the following information)

  • WSL (Windows Subsystem for Linux)
  • Branch: < develop

Additional context

None
@athoynilimanew athoynilimanew added the bug Something isn't working label Feb 19, 2024
@athoynilimanew athoynilimanew mentioned this issue Feb 19, 2024
Merged
3 tasks
@je-cook je-cook mentioned this issue Feb 27, 2024
Merged
3 tasks
je-cook added a commit that referenced this issue Feb 29, 2024
@athoynilimanew @je-cook
#3030: Modifications needed to run process (#3031)
ce60741 
* ✅ Add some missing model switches for process

* 🐛 fix model_mapping

* ✅ Organise newly added input parameters

* 🐛 Delete "likely duplicated" mapping but change the return value in the existing mapping

* ✅ add model mapping for Stellerator Blanket Model

* ✅ Add missing variables in inputs.py

* Update bluemira/codes/process/_inputs.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* ✅ Add further info in ()

* Update bluemira/codes/process/model_mapping.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* Update bluemira/codes/process/_inputs.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* Update bluemira/codes/process/_inputs.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* Update bluemira/codes/process/_inputs.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* Update bluemira/codes/process/model_mapping.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* Update bluemira/codes/process/model_mapping.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* Update bluemira/codes/process/model_mapping.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* Update bluemira/codes/process/model_mapping.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* 🐛 remove extra "," in model mapping

---------

Co-authored-by: Athoy Nilima <athoy.nilima@ukaea.uk>
Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>
OceanNuclear pushed a commit that referenced this issue Jun 17, 2024
@athoynilimanew @je-cook @OceanNuclear
#3030: Modifications needed to run process (#3031)
9d54b5e 
* ✅ Add some missing model switches for process

* 🐛 fix model_mapping

* ✅ Organise newly added input parameters

* 🐛 Delete "likely duplicated" mapping but change the return value in the existing mapping

* ✅ add model mapping for Stellerator Blanket Model

* ✅ Add missing variables in inputs.py

* Update bluemira/codes/process/_inputs.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* ✅ Add further info in ()

* Update bluemira/codes/process/model_mapping.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* Update bluemira/codes/process/_inputs.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* Update bluemira/codes/process/_inputs.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* Update bluemira/codes/process/_inputs.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* Update bluemira/codes/process/model_mapping.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* Update bluemira/codes/process/model_mapping.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* Update bluemira/codes/process/model_mapping.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* Update bluemira/codes/process/model_mapping.py

Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

* 🐛 remove extra "," in model mapping

---------

Co-authored-by: Athoy Nilima <athoy.nilima@ukaea.uk>
Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3030: Modifications needed to run process athoynilimanew/bluemira
1 participant
@athoynilimanew