Hide dropdown none option when not needed

FurqanSoftware · Feb 22, 2024 · be69beb · be69beb
1 parent 9742b56
commit be69beb
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/widgets/dropdown/index.js b/src/widgets/dropdown/index.js
@@ -91,14 +91,15 @@ class Dropdown {
 			const menu = dom.$('.dropdown__menu', this.el)
 			for (const el of dom.$$('.dropdown__item', menu)) dom.detach(el)
 
+			const select = dom.$('select', this.el)	
+
 			const addItem = (data) => {
 				const { label, value, empty, ...rest } = data
 
 				const item = this.makeItem(data)
 				menu.appendChild(item)
 
-				if (dom.hasClass(this.el, '-select')) {
-					const select = dom.$('select', this.el)	
+				if (select) {
 					dom.on(item, 'click', () => {
 						if (empty) {
 							select.innerHTML = ''
@@ -133,7 +134,8 @@ class Dropdown {
 				}
 			}
 
-			addItem({ label: 'None', value: '', empty: true })
+			if (select && (select.multiple || dom.$('option[data-empty]', select))) addItem({ label: 'None', value: '', empty: true })
+
 			for (const item of items) addItem({ ...item, label: item.text, value: item.id })
 
 			this.reposition()