[BUG] Have issue with Unity stripping away data from classes (ex. Dissonity.Models.Interop.InteropMessage

[ETdoFresh]

Describe the bug
When in WebGL build in Discord, I have an issue where the hiRPC is not working.

Reproduction
I cannot show exactly the code that I'm using, but it's not very complex, and it really just gets stuck at
await Dissonity.Api.Initialize()

Expected behavior
It should not get stuck. But, I found the reason as shown in the screenshot.

Screenshots

Logged from DissonityBridge.cs#L260-L261
[It early returns because hiRPC message is null... maybe instead of early return, it should be an exception?]

Platform
WebGL

Additional context
Here are two workarounds/fix. I can put a workaround as a PR if desired. Just let me know which one.

Workaround/Fix 1
Add link.xml to your Assets folder

<linker>
    <assembly fullname="Furnyr.Dissonity" preserve="all"/>
</linker>

Workaround/Fix 2
Add [UnityEngine.Scripting.Preserve] on stripped classes or properties.

[Furnyr]

Thank you for reporting! I will look into this further when I have time, but your screenshot is helpful to begin with.

It seems that C# receives hirpc_state with a value of 0, which is odd because that should only happen if the activity is executed outside a web environment (when window is not defined).

But stringifiedData has hirpc_state: 4 and a complete hiRPC handshake, which should be the first message that gets to the DissonityBridge in the C# layer.

The early return is there because during a normal activity runtime, hiRPC messages contain either a message sent by Discord (rpc_message) or a message sent from JavaScript (hirpc_message), but they should never carry null data.

---

About the Preserve attribute, have you tested whether that fixes it? I believe all the classes are used so it would be surprising if Unity is stripping classes away.

Any additional information is helpful, such as:

• Unity version
• Managed Stripping Level (In Unity 6: Player Settings > Other Settings > Optimizations)

[ETdoFresh]

Of course!

Unity 2022.3.8f1

And... as far as preserve... I didn't know which one to add it too... but something is definitely getting stripped...

I did try adding Assets/Dissonity/link.xml ... and it works everytime after that... so something is getting removed... but I don't have a good mechanism on telling you what it is.

[wizardjo]

@ETdoFresh Hi, could you please explain me what do you added to Assets/Dissonity/link.xml ? Thanks

[wizardjo]

@ETdoFresh Thanks, I saw the code.

[Furnyr]

I am able to reproduce the issue, it is indeed Unity stripping classes away, possibly because some are only used for reflection when deserializing mesages. It's a pretty complicated issue because I believe it only happens in some specific Unity versions, and only when the package is installed through the Package Manager, and not during local development.

It affects classes through the whole codebase, so I agree that generating a link.xml file in the Dissonity folder would be the ideal solution, at least for now.

I hope to be able to release a fix in v2.0.1 sometime next week, but I will keep you updated.

Thanks again for reporting this bug, I wouldn't have discovered it otherwise 👍

[Furnyr]

As mentioned in the Release Notes, link.xml should now be automatically added to Assets/Dissonity.

Let me know if there's anything else that needs to be addressed.