adding check for no Mixpanel.superProperties object closes segment-in…

…tegrations#11
FunnelEnvy · Sep 8, 2015 · 9bdcd57 · 9bdcd57
1 parent d0b360a
commit 9bdcd57
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/index.js b/lib/index.js
@@ -151,7 +151,7 @@ Mixpanel.prototype.identify = function(identify) {
 
   // explicitly set select traits as people and super properties
   var opts = identify.integrations() || {};
-  opts = opts[this.name];
+  opts = opts[this.name] || {};
   var superProps = pick(opts.superProperties || [], traits);
   var peopleProps = pick(opts.peopleProperties || [], traits);
   if (!is.empty(superProps)) window.mixpanel.register(superProps);

diff --git a/test/index.test.js b/test/index.test.js
@@ -320,6 +320,11 @@ describe('Mixpanel', function() {
         analytics.called(window.mixpanel.people.set, { friend: 'elmo' });
       });
 
+      it('shouldn\'t try to register super properties if not specified', function() {
+        analytics.track('event', { friend: 'elmo' }, {});
+        analytics.didNotCall(window.mixpanel.register);
+      });
+
       it('should convert dates to iso strings', function() {
         var date = new Date();
         analytics.track('event', { date: date });